Linux creator Linus Torvalds has publicly criticized kernel developers for submitting ‘garbage’ patches late in the merge window, particularly highlighting a set of RISC-V patches by Meta software engineer Palmer Dabbelt. Torvalds emphasized the importance of quality and timely submissions, warning against late pull requests and poor code quality that could negatively impact the broader Linux community. Torvalds had previously warned developers about the upcoming merge window for 6.17, noting his travel plans for the month of August due to family events. Despite this, Dabbelt pushed through a set of RISC-V patches late, which Torvalds found unacceptable.
The Linux Kernel Mailing List (LKML) saw Torvalds issuing a strong rebuke, calling the patches ‘garbage’ and expressing frustration over their late submission. He pointed out that the code added various unnecessary elements to generic header files, which he argued could negatively impact the wider Linux community. Specifically, Torvalds criticized a helper function that combined two unsigned 16-bit integers into a 32-bit integer, calling it ‘crazy and pointless.’ He argued that such a function made the world a worse place to live, emphasizing the need for high-quality code that does not compromise the user experience.
Dabbelt acknowledged the criticism, apologizing for his mistakes and vowing to improve. He admitted to dropping the ball and making errors due to accumulated delays, which led to late submissions. While he recognized the problem, Torvalds made it clear that the issue was not just about timing but also the quality of the code. The incident has sparked a discussion within the Linux community about the importance of adhering to submission guidelines, maintaining high standards, and avoiding the pitfalls of late and low-quality contributions. The debate continues as the Linux community looks for ways to ensure the continued excellence of its core kernel.