Linus Torvalds, the principal maintainer of the Linux kernel, has rejected the RISC-V architecture changes for the Linux 6.17 kernel, citing both late submission and poor code quality. The updates were submitted just in time for the merge window, which closes on Sunday, but Torvalds expressed frustration over their lateness, especially during his international travel period. His main criticisms focused on the inclusion of non-RISC-V specific code in generic header files, which he labeled as ‘garbage.’ Torvalds specifically criticized a function called make_u32_from_two_u16(), calling it pointless and detrimental to code clarity.
The rejection of the RISC-V changes has sparked a discussion within the open-source community about the importance of adhering to submission timelines and maintaining high code quality standards. Many developers have echoed Torvalds’ sentiments, emphasizing the need for timely and well-crafted contributions to ensure the stability and reliability of the Linux kernel. Torvalds’ response to the submitter was firm, highlighting that the quality of the code should not be compromised by late submissions. He also warned that future pull requests should be submitted early and adhere to the project’s coding standards.
The submitter of the patches acknowledged the criticism and pledged to avoid late submissions and improve code quality moving forward. This incident underscores the rigorous standards expected within the Linux kernel development process and the critical role of maintainers in ensuring the integrity of the project. As the Linux community continues to evolve, such incidents serve as reminders of the importance of collaboration, responsibility, and adherence to best practices in open-source development.